Alarm Panel card: number buttons outline and adjusted padding and font-size fixing #2812#3991
Alarm Panel card: number buttons outline and adjusted padding and font-size fixing #2812#3991bramkragten merged 5 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
|
it's not absolutely best but a possible solution before mwc-button height bug is sorted out. |
mr-awk
changed the title
mr-awk
changed the title
| outlined | ||
| > | ||
| ${this._label(state)} | ||
| <h1 style="font-size:16px;">${this._label(state)}</h1> |
| ${value === "clear" | ||
| ? this._label("clear_code") | ||
| : value} | ||
| <h1 style="font-size:16px;"> |
There was a problem hiding this comment.
Don't use h1 inside a button, that's a header tag
|
I don't thing this looks good, let's keep all the font sizes normal, and just add a outline on the buttons. |
Okey, thought this could be a possible solution. I know it is not a good looking or very smart but it works, and help for people who is visual impaired. |
|
I suggest this: I can push my changes to your branch if you want? With a base font of 20px instead of 14px it would look like this: |
|
No problem, I can fix it. Just missed the raised part. Will push that change in one-two hours.
Best regards,
Marcus
… 14 okt. 2019 kl. 09:32 skrev Bram Kragten ***@***.***>:
I suggest this:
I can push my changes to your branch if you want?
Removing the base unit will make sure that the font sizes can scale when settings change. Not sure if it is possible to set font-size with a theme, but we might want to look into that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@bramkragten Sorry didn't read your whole post. Please push your changes! |
|
ah, nice find @bramkragten. That makes sense now. |
4 participants
Thanks to @bramkragten for helping out.
Outline on buttons and less padding.
Found a solution for the font-size issue before mwc-button height bug is fixed.
fixes #2812